18649 - Issue Log

18649 Fall 2015
Group 12 - Tom Eliot (tke), Shepard Emerson (semerson), Daniel Gorziglia (dgorzigl), Daniel Haddox (dhaddox)
This table has an entry for each design issue during the semester.  Add new entries to the bottom of the table (you may need to add new rows).  Leave all the previous entries in place so that at the end of the project you have a complete list of the design changes that you have made throughout the project.  The meaning of the table entries is as follows:

Issue #
 Date Found
 Date Fixed
 Change Made By
 Origin
 Description
 Resolution
 Artifact(s) Changed
1
 9/23/15
 9/23/15
 Shepard Emerson
 Sequence Diagram 3A
 LanternControl was triggered from mDesiredFloor, changed to mDoorClosed.
 Sequence diagram updated to agree with behavioral requirements.
 Sequence Diagram 3A
2
 9/23/15
 9/23/15
 Shepard Emerson
 Sequence Diagram 7A
 LanternControl was triggered from mDesiredFloor, changed to mDoorClosed.
 Sequence diagram updated to agree with behavioral requirements.
 Sequence Diagram 7A
3
 9/23/15
 9/23/15
 Daniel Gorziglia
 Sequence Diagram 2A
 CarCallControl should have been called CarButtonControl
 Changed label to CarButtonControl
 Sequence Diagram 2A
4
 9/23/15
 9/23/15
 Daniel Gorziglia
 Sequence Diagram 2B
 CarCallControl should have been called CarButtonControl
 Changed label to CarButtonControl
 Sequence Diagram 2B
5
 9/24/15
 9/24/15
 Shepard Emerson
 Sequence Diagram 3A
 4c should have been 4b
 Changed 4c label to 4b
 Sequence Diagram 3A
6
 9/24/15
 9/24/15
 Daniel Haddox
 Sequence Diagram 7A
 CarLantern should be set to On, not just set
 Set value to on
 Sequence Diagram 7A
7
 9/23/15
 9/23/15
 Tom Eliot
 Sequence Diagrams 1b,1c,2a,5a,5b,7c,8a,9a
 DoorMotor close should not be used
 set DoorMotor to nudge
 Sequence Diagrams 1b,1c,2a,5a,5b,7c,8a,9a
8
 9/24/15
 9/24/15
 Shepard Emerson
 Sequence Diagram 9
 mDesiredFloor should not have had brackets
 Removed brackets from mDesiredFloor
 Sequence Diagram 9
9
 9/24/15
 9/24/15
 Daniel Haddox
 Sequence Diagram 7C
 CarLantern should be turned off when the door closes
 LanternControl turns the CarLantern off when a door closes
 Sequence Diagram 9
10
 9/24/15
 9/24/15
 Tom Eliot
 Sequence Diagram 9
 DesiredFloor triggers on mdoorclosed=false
 changed sequence diagram to include mdoorclosed=false
 Sequence Diagram 9
11
 9/24/15
 9/24/15
 Shepard Emerson
 Sequence Diagram 8A
 Drive should be commanded slow by doorClosed not mDoorMotor
 Made drive commanded slow by doorClosed
 Sequence Diagram 8A
12
 9/24/15
 9/24/15
 Daniel Haddox
 Sequence Diagram 10
 Needed to add a sequence to deal with overweight sensor
 added use case for passenger entering overweight elevator
 Use Case 10
13
 9/24/15
 9/24/15
 Tom Eliot
 Sequence Diagram 9A
 Doors must be triggered by mDriveSpeed
 Made doors triggered by mDriveSpeed and AtFloor
 Sequence Diagram 9A
14
 9/29/15
 9/29/15
 Daniel Gorziglia
 Scenario & Sequence Diagram 4A
 Scenario did not turn off the car button
 Scenario + sequence diagram included to turn off car button
Scenario & Sequence Diagram 4A
15
 9/29/15
 9/29/15
 Daniel Gorziglia
 Scenario & Sequence Diagram 3A
 Scenario did not turn off the hall light
 Scenario + sequence diagram included to turn off hall light
Scenario & Sequence Diagram 3A
16
 10/6/15
 10/6/15
 Daniel Haddox
 DriveControl Statechart
 6.T.3 and 6.T.4 arcs labeled backwards
 swapped arc labels
DriveControl Statechart
17
 10/6/15
 10/6/15
 Daniel Gorziglia
 CarButtonControl Transition
 9.T.2 is missing a condition
 added condition (mAtFloor == TRUE)
 CarButtonControl Transition
18
 10/15/15
 10/15/15
 Shepard Emerson
 LanternControl Statechart
 Both states should set mCarLantern
 Added output for message in both states
 LanternControl Statechart
19
 10/15/15
 10/15/15
 Shepard Emerson
 LanternControl Transitions
 7.T.1 should be != True
 Changed 7.T.1 to mDoorClosed[*,*] != True
 LanternControl Transitions
20
 10/15/15
 10/15/15
 Daniel Haddox
 Dispatcher Statechart
 Door closed state should set hallway to none
 fixed statechart
 Dispatcher State Chart
21
 10/15/15
 10/15/15
 Daniel Haddox
 Dispatcher State Variables
 STD and code assume a state variable that wasnt in req2
 added currentHallway state variable to req2
 Dispatcher State Variables
22
 10/16/15
 10/16/15
 Shepard Emerson
 Sequence Diagram 9A
 Needs CarLight for traceability, message passing and triggers incorrect
 Added CarLight messages, fixed message passing issues
 Sequence Diagram 9A
23
 10/16/15
 10/16/15
 Daniel Gorziglia
 Sequence Diagram 2B
 Sequence Diagram not suitable for integration tests
 Simpliefied diagram + redid traceability for SD.
 Sequence Diagram 2B
24
 10/16/15
 10/16/15
 Daniel Gorziglia
 Sequence Diagram 9A
 Sequece Diagram needs to trace to 9.2.2
 Pending fix.
 Sequence Diagram 9A
25
 10/16/15
 10/16/15
 Shepard Emerson
 LanternControl Statechart
 Transition 7.T.1 needs case for desireddirection to be the lantern's direction.
 Added condition to 7.T.1
 LanternControl Statechart
26
 10/16/15
 10/16/15
 Tom Eliot
 Sequence Diagram 4A
 Car light turned off after door opened
 Arcs moved so car light turns off on doorclosed = false
 Sequence Diagram 4A
27
 10/20/15
 10/20/15
 Daniel Haddox
 Integration Test Log
 4A,11A missing from log
 Added 4A, 11A to log
 Integration Test Log
28
 10/20/15
 10/20/15
 Daniel Haddox
 LanternControl Transition Conditions
 Transmission 7.T.1 should check DesiredDirection macro, not mDesiredFloor.d (direction)
 fixed transition table in requirements 2
 Requirements 2 LanternControl Transition condition
29
 10/20/15
 10/20/15
 Daniel Haddox
 Sequence Diagram 8A
 CarPositionControl is in the sequence diagram when it doesn't need to be
 removed CarPositionControl from SD8a and traceability spreadsheet
 Sequence Diagram 8A
30
 10/20/15
 10/20/15
 Shepard Emerson
 Sequence Diagram 1B, 1C
 Arc 3A incorrectly labeled as local object message
 Changed arc label to reflect that passenger pressed button
 Sequence Diagram 1B, 1C
31
 10/21/15
 10/21/15
 Shepard Emerson
 Sequence Diagram 2A
 Post condition says both doors are closed, should be one
 Changed postconditions to say one door (in precondition) is closed
 Sequence Diagram 2A
32
 10/21/15
 10/21/15
 Daniel Gorziglia
 HallButtonControl
 Replication was incorrectly used for atFloor CAN mailbox
 Changed replication computer usage for HallCuttonControl
 HallButtonControl
33
 10/21/15
 10/21/15
 Daniel Haddox
 Sequence Diagram 3A
 Arc 3b read mHallLight when it should read HallLight
 Changed to HallLight
 Sequence Diagram 3A
34
 10/21/15
 10/21/15
 Daniel Gorziglia
 Sequence Diagram 3A
 SD needs Dispatcher
 Added Dispatcher to sequnece iagram to properly trigger hallbuttoncontrol.
 Sequence Diagram 3A
35
 10/21/15
 10/21/15
 Shepard Emerson
 DriveControl State Transition Diagram
 Transitions T3, T4 backwards
 Switched T3 and T4
 DriveControl State Transition Diagram
36
 10/21/15
 10/21/15
 Shepard Emerson
 Dispatcher Code
 Dispatcher transition from doors_closed to doors_not_closed condition wrong
 Changed == 1 to != -1
 Dispatcher Code
37
 10/21/15
 10/21/15
 Thomas Eliot
 DriveControl Requirements 2
 Leveling needed to be added
 Added states 4,5 transitions 5,6,7,8, leveling behavioral requirements, DriveControl leveling implementation, SD 3b
 DriveControl Requirements 2, DriveControl SD, DriveControl unit test, DriveControl implementation
38
 10/21/15
 10/21/15
 Shepard Emerson
 DoorControl Transition 5.T.1
 Weight check needs to check that there is a landing
 Added landing check to weight check
 DoorControl Transition 5.T.1
38
 10/21/15
 10/21/15
 Daniel Gorziglia
 Sequence Diagram 7A
 Sequence diagram needs Dipatcher
 Added Dispatcher to SD + changed ordering
 Sequence Diagram 7A
39
 10/25/15
 10/25/15
 Daniel Haddox
 Sequence Diagram 7A
 Sequence Diagram had arcs going from Lantern to LanternControl
 fixed arrow direction
 Sequence Diagram 7A
40
 10/25/15
 10/25/15
 Daniel Haddox
 Sequence Diagram 3A
 LanternControl and HallButtonControl needed to receive mDesiredFloor, but only had arc going HallButton
 fixed sequence diagram, need to fix traceability before next handin
 Sequence Diagram 7A, traceability
41
 10/28/15
 10/28/15
 Shepard Emerson
 Dispatcher implementation, statechart
 Acceptance test 3 does not pass because the elevator doesn't pick up passengers on the way down
 Updated dispatcher to command elevator to stop at floors going down as well as up.
 Dispatcher implementation, statechart
42
 10/28/15
 10/28/15
 Shepard Emerson
 DriveControl implementation, statechart
 Sometimes the car tries to level when drive has not fully stopped (goes from down to level up, for example)
 Added check in transitions 6.T.5, 6.T.7 for drive speed to be stopped
 DriveControl implementation, statechart
43
 10/28/15
 10/28/15
 Daniel Gorziglia
 Sequence Diagram 5A and 5B
 Sequence diagrams needed to be updated to reflect new high level requirements for door reversal behavior.
 Updated sequence diagrams to reflect new requirements.
 Sequence Diagram 5A and 5B
44
 10/28/15
 10/28/15
 Daniel Gorziglia
 DoorControl Requirements
 Time triggered requirements need to be updated to reflect new high-level requirements.
 Updated DoorControl time triggered requirements to reflect new high level requirements.
 DoorControl Requirements
45
 10/28/15
 10/28/15
 Daniel Gorziglia
 Sequence Diagrams 7B, 9A
 SDs needs new pre condition to make DoorControl requirements relevant
 Updated sequence diagrams to include new pre-conditions
 Sequence Diagrams 7B, 9A
46
 10/28/15
 10/28/15
 Daniel Haddox
 Dispatcher
 Logic for sabath elevator is too slow. Dispatcher requirements are too simple for the design goal at this point in the project.
 Updated dispatcher requirements to more appropriately set mDesiredFloor
 Dispatcher Behavioral Requirements
47
 10/28/15
 10/28/15
 Shepard Emerson
 Integration Test 9A
 Integration test 9a needs to be udpated to reflect new dispatcher statechart
 Integration test 9a updated
 Integration Test 9A
48
 10/28/15
 10/28/15
 Shepard Emerson
 Dispatcher Unit Test
 Dispatcher unit test needs to be updated to reflect new statechart
 Dispatcher unit test updated and passing
 Dispatcher Unit Test
49
 10/29/15
 10/29/15
 Daniel Haddox
 SD7A
 scenario and sequence diagram out of date due to new high level requirements and dispatcher / laterncontrol requirements
 Sequence diagram preconditions updated to meet new high level requirements RT-8.1 and RT-8.2, also updated to match new dispatcher / lantern control requirements
 Scenario 7A Preconditions, SD7A
50
 10/29/15
 10/29/15
 Daniel Haddox
 SD3A
 scenario and sequence diagram out of date due to new high level requirements and dispatcher / laterncontrol requirements
 Sequence diagram preconditions updated to meet new high level requirements RT-8.1 and RT-8.2, also updated to match new dispatcher / lantern control requirements
 Scenario 7A Preconditions, SD7A
51
 10/29/15
 10/29/15
 Tom Eliot
 R-T10
 Doors can now close instead of nudge
 Sequence diagrams updated to close instead of nudge
 SD 1b, 1c, 2a, 2b, 5a, 5b, 7c, 8a
52
 10/29/15
 10/29/15
 Tom Eliot
 R-T9
 Drive must now go fast
 Sequence diagrams updated to cause drive to go fast
 SD 8a
53
 10/29/15
 10/29/15
 Tom Eliot
 R-T9
 CarPositionControl must calculate commit point
 Sequence diagram updated to have mCarLevelIndictor
 SD 6a
54
 10/29/15
 10/29/15
 Tom Eliot
 R-T9
 CarPositionControl must calculate commit point
 Requirements updated to calculate commit point and use for carpositionindicator
 CarPositionControl requirements
55
 10/29/15
 10/29/15
 Tom Eliot
 R-T9
 Drivecontrol must now go fast
 Requirements updated to transition from slow to fast and back
 DriveControl requirements
56
 10/29/15
 10/29/15
 Daniel Haddox
 SD 3A
 SD 3A mDesiredFloor message and CarLantern didnt match new tt reqs
 SD3A updated to proper mDesireFloor message and CarLantern actions
 SD3A
57
 11/5/15
 11/11/15
 Tom Eliot
 Dispatcher Implementation
 Error with registering HallCalls, fails on construction during unit test
 Changed dispatcher constructor and helper functions to use utility.java
 Dispatcher.java
58
 11/11/15
 11/11/15
 Tom Eliot
 Dispatcher Implementation
 Dispatcher state chart outputs not set correctly, helper functions compute incorrectly
 Fixed bugs in statechart and helper functions
 Dispatcher.java
59
 11/11/15
 11/11/15
 Tom Eliot
 Dispatcher Unit Test
 Test does not wait long enough for transition, test asserts wrong floor
 Changed message timings and assertions
 Dispatcher_test1.mc
60
 11/11/15
 11/11/15
 Tom Eliot
 Dispatcher Unit Test
 Test does not wait long enough for transition, test asserts wrong floor
 Changed message timings and assertions
 Dispatcher_test1.mf
60
 11/11/15
 11/11/15
 Tom Eliot
 Dispatcher Requirements
 Transitions 11.T.5&3, 11.T.8&6, 11.T.6&7, 11.T.3&4 not mutually exclusive
 changed 11.T 3, 5, 6, 8
 requirements2.html
61
 11/12/15
 11/12/15
 Tom Eliot
 DoorControl Requirements
 5.T.5 needs to open on mDF.b = BOTH
 changed reqs2, implementation
 requirements2.html, DoorControl.java
62
 11/12/15
 11/12/15p
 Shepard Emerson
 DriveControl Implementation
 timerExpired has magic nubmers and needs to be clearer with more comments
 -
 DriveControl.java
63
 11/12/15
 11/12/15
 Daniel Gorziglia
 DriveControl Implementation
 Bug with doors reopening at floors
 -
 DoorControl.java
64
 11/12/15
 11/12/15
 Daniel Gorziglia
 CarPositionControl Implementation
Magic numbers and poorly commented code
 -
 CarPositionControl.java
65
 11/19/15
 11/19/15
 Shepard Emerson
 Sequence Diagram 7C
 Arc 3B is labeled incorrectly
 Renamed arc 3B label
 Sequence Diagram 7C
66
 11/19/15
 11/19/15
 Daniel Gorziglia
 Sequence Diagram 1F
 Arc 1b is labeled incorrectly
 Renamed arc 1b label
 Sequence Diagram 1F
67
 11/19/15
 11/19/15
 Daniel Gorziglia
 Sequence Diagram 2B
 Arc 1b is labeled incorrectly
 Renamed arc 1b label
 Sequence Diagram 2B
68
 11/19/15
 11/19/15 Daniel Gorziglia Integration Test 1A Test updated to reflect new sequence diagram + network messages Updated test Integration Test 1A
69
 11/19/15
 11/19/15 Daniel Gorziglia Integration Test 1B Test updated to reflect new sequence diagram + network messages Updated test Integration Test 1B
70
 11/19/15
 11/19/15 Daniel Gorziglia Integration Test 1C Test updated to reflect new sequence diagram + network messages Updated test Integration Test 1C
71
 11/19/15
 11/19/15 Daniel Gorziglia Integration Test 2A Test updated to reflect new sequence diagram + network messages Updated test Integration Test 2A
72
 11/19/15
 11/19/15 Daniel Gorziglia Integration Test 2B Test updated to reflect new sequence diagram + network messages Updated test Integration Test 2B
73
 11/19/15
 11/19/15 Daniel Gorziglia Integration Test 5A Test updated to reflect new sequence diagram + network messages Updated test Integration Test 5A
74
 11/19/15
 11/19/15 Daniel Gorziglia Integration Test 5B Test updated to reflect new sequence diagram + network messages Updated test Integration Test 5B
75
 11/19/15
 11/19/15 Shepard Emerson Integration Test 7C Test updated to reflect new sequence diagram + network messages Updated test Integration Test 7C
76
 11/19/15
 11/19/15 Shepard Emerson DriveControl, DoorControl, CarPositionControl, Dispatcher Unit Tests Message CAN IDs and translators incorrect after message update Updated all CAN IDs and translators in unit tests DriveControl, DoorControl, CarPositionControl, Dispatcher Unit Tests
77
 12/4/15
 12/4/15 Daniel Haddox CarButtonControl StateChart Removed servicing state Updated code / documentation to remove servicing state CarButtonControl Requirements, Statechart, Transitions, Requirements to Statechart Traceability, Code, Unit test
78
 12/4/15
 12/4/15 Daniel Haddox HallButtonControl StateChart Removed servicing state Updated code / documentation to remove servicing state HallButtonControl Requirements, Statechart, Transitions, Requirements to Statechart Traceability, Code, Unit test
79
 12/4/15
 12/4/15 Daniel Haddox DoorControl Requirementss requirements incorrectly state to check calls at floor Updated documentation to remove check, removed duplicate reqs 5.7.1/2 DoorControl Requirements, requirements to statechart tracecability
80
 12/7/15
 12/7/15 Shepard Emerson HallButtonControl Requirements, Statechart, Traceability HallButtonControl needs Servicing state added back to avoid door cycling on floor 1 Added servicing state back to HallButtonControl, updated requirements and traceability to match HallButtonControl Requirements, Statechart, Traceability
81
 12/7/15
 12/7/15 Shepard Emerson Sequence Diagram 2A, Sequence Diagram 2B Sequence diagram needs to be updated to reflect removal of Servicing state from CarButtonControl Removed Servicing from sequence diagrams Sequence Diagram 2A, Sequence Diagram 2B
82
 12/7/15
 12/7/15 Shepard Emerson LanternControl implementation, statechart, requirements, traceability, unit test LanternControl needs a latching state due to timing changes of dispatcher Added latching state to LanternControl LanternControl implementation, statechart, requirements, traceability, unit test
83
 12/7/15
 12/7/15 Daniel Gorziglia DoorControl Implementation Found a bug where doors will not open when in nudge state and overweight sensor trips Added another transition to open doors if overweight occurs DoorControl Implementation
84
 12/7/15
 12/7/15 Daniel Haddox SD3A Did not trace to new dispatcher reqs Updated to meet dispatcher req changes SD3A
85
 12/7/15
 12/15/15 Tom Eliot DriveControl Implementation Does not check for DoorMotor equals open Updated files to check for DoorMotor equals open, added utility functions to Utility.java DriveControl Implementation, Unit Tests, Integration Tests, Transitions